Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Metrics UI] Minor fixes to inventory timeline #78226

Merged
merged 4 commits into from
Sep 23, 2020
Merged

[Metrics UI] Minor fixes to inventory timeline #78226

merged 4 commits into from
Sep 23, 2020

Conversation

Zacqary
Copy link
Contributor

@Zacqary Zacqary commented Sep 22, 2020

Summary

Missed some feedback before merging #77804, as it was posted on the original issue instead of the PR (#73962 (comment))

  • Reverts the interval label text and adds "for the selected time" back
  • Uses new logic for determining the timeline length. Bucket interval is now a minimum of 5 minutes and displays over a 24 hour period. Larger intervals display over a 3 day period, 1 week period, or 1 month period.

Checklist

@Zacqary Zacqary added Feature:Metrics UI Metrics UI feature v8.0.0 Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services release_note:skip Skip the PR/issue when compiling release notes v7.10.0 labels Sep 22, 2020
@Zacqary Zacqary requested a review from a team as a code owner September 22, 2020 21:54
@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

async chunks size

id value diff baseline
infra 3.9MB +384.0B 3.9MB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@simianhacker simianhacker self-assigned this Sep 23, 2020
@simianhacker simianhacker self-requested a review September 23, 2020 18:31
simianhacker
simianhacker approved these changes Sep 23, 2020
View reviewed changes
Copy link
Member

@simianhacker simianhacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Zacqary Zacqary merged commit f9e0679 into elastic:master Sep 23, 2020
@Zacqary Zacqary deleted the inventory-timeline-fix branch September 23, 2020 18:53
Zacqary added a commit to Zacqary/kibana that referenced this pull request Sep 23, 2020
@Zacqary
[Metrics UI] Minor fixes to inventory timeline (elastic#78226)
a173386
@Zacqary Zacqary mentioned this pull request Sep 23, 2020
Merged
Zacqary added a commit that referenced this pull request Sep 23, 2020
@Zacqary
[7.x] [Metrics UI] Minor fixes to inventory timeline (#78226) (#78339)
3b75b1b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simianhacker simianhacker simianhacker approved these changes

Assignees

@simianhacker simianhacker

Labels
Feature:Metrics UI Metrics UI feature release_note:skip Skip the PR/issue when compiling release notes Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.10.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Zacqary @elasticmachine @kibanamachine @simianhacker